[PATCH] D64549: [ELF] Warn rather than error when duplicate version assignments occur

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 11 03:29:28 PDT 2019


ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: ELF/SymbolTable.cpp:204
 
+  auto getName = [&](uint16_t ver) -> std::string {
+    if (ver == VER_NDX_LOCAL)
----------------
It looks like this function doesn't capture anything, so I believe you can remove `&`.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64549/new/

https://reviews.llvm.org/D64549





More information about the llvm-commits mailing list