[PATCH] D64427: LLVM Test-Suite: Support Cross-Compilation and Cross-execution targeting arm64-linux-android

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: cmake/caches/target-arm64-android-template.sh:1
+#!/bin/bash
+rm -rf CMakeCache.txt
----------------
I think `cmake/caches` should only contain cmake cache files (a set of pre-configured settings), that can be used with `cmake -C`, not bash scripts.

IIUC the key thing to do here is to locate the android ndk and set the paths accordingly. Is there a standard way to locate the ndk, similar to how it is done for the Xcode SDKs ? (like https://github.com/llvm/llvm-test-suite/blob/master/cmake/caches/util/xcode_sdk.cmake)


================
Comment at: cmake/caches/target-arm64-android-template.sh:6
+# REQUIRED: path to the test-suite source file
+TEST_SUITE_LOCATION="/data/local/tmp/devspace/test-suite"
+# REQUIRED: path to android ndk that contains necessary header files and libraries
----------------
This setting and the ones below seems very system/setup specific, and related to general test-suite setup, not android related.


================
Comment at: cmake/caches/target-arm64-android-template.sh:42
+# Push the shared library libc++_shared.so onto the device.
+adb -s $DEVICE_SERIAL push $ANDROID_NDK_LOCATION/toolchains/llvm/prebuilt/\
+$HOST_SYSTEM/sysroot/usr/lib/aarch64-linux-android/libc++_shared.so \
----------------
Can this be handled by the general sync logic, that copies over the other artifacts? Also, is using a libcxx built alongside clang supported?


Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64427/new/

https://reviews.llvm.org/D64427