[PATCH] D61597: [test-suite] Fix support for user mode emulation when using cmake/lit.

Thu Jul 11 02:22:32 PDT 2019

lenary accepted this revision.
lenary added a comment.
This revision is now accepted and ready to land.

In D61597#1577801 <https://reviews.llvm.org/D61597#1577801>, @kristof.beyls wrote:

> FWIW, I also have a downstream patch for LNT to use comma as the separator, rather than semi-colon. I find that results in less clicking being needed when opening the CSV file in Excel. Happy to upstream that too if you also find out that commas, rather than semi-colons, as a field separator in CSV files works better.

I don't mind so much about the CSV being semicolon-separated, I can cope with the extra clicks, and I don't want to break anyone else's systems. That said, happy for you to post the patch so further discussion can happen.

> Could you on this review mark that you've approved this patch ("Accept Revision")? Maybe you'll need to first make yourself a reviewer to be able to do that - I'm not sure.

Sure, done!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61597/new/

https://reviews.llvm.org/D61597