[PATCH] D64501: [ARM][LowOverheadLoops] Correct offset checking

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks like a good fix to me.



================
Comment at: lib/Target/ARM/ARMLowOverheadLoops.cpp:211
+  }
+  if (Start->getOpcode() == ARM::t2WhileLoopStart &&
+      (BBUtils->getOffsetOf(Start) >
----------------
samparker wrote:
> SjoerdMeijer wrote:
> > I am wondering why here the opcode is checked (WLS), but why that is not necessary above for LE....
> Because 'End' can only be LE, whereas 'Start' can be DLS or WLS, and DLS doesn't use an offset.
Ah, of course, cheers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64501/new/

https://reviews.llvm.org/D64501