[PATCH] D64549: [ELF] Warn rather than error when duplicate version assignments occur

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/SymbolTable.cpp:212-214
+    if (sym->versionId == config->defaultSymbolVersion) {
+      sym->versionId = versionId;
+    } else if (sym->versionId != versionId) {
----------------
Is there any way to do early-continue to reduce indentation?


================
Comment at: ELF/SymbolTable.cpp:215
+    } else if (sym->versionId != versionId) {
+      std::string msg = ("symbol '" + ver.name + "' was assigned").str();
+      if (sym->versionId == VER_NDX_LOCAL)
----------------
I would inline this and remove the variable.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64549/new/

https://reviews.llvm.org/D64549