[PATCH] D64461: [lld-link] implement -thinlto-index-only

Wed Jul 10 22:39:12 PDT 2019

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: lld/COFF/LTO.cpp:57
+
+static std::string getThinLTOOutputFile(StringRef ModulePath) {
+  return ModulePath;
----------------
inglorion wrote:
> inglorion wrote:
> > rnk wrote:
> > > I guess this is mainly a future extension point for prefix rewriting, so we can have different .thinlto.bc index files for different executable targets.
> > Exactly. The ELF linker allows prefix and suffix replace here, and we'll want that for the COFF linker, too. Patch is coming.
> Originally I had the prefix and suffix replace code in this patch, but I broke it up into smaller pieces.
Please move this https://reviews.llvm.org/D64542 so that this identity function is not included in the first patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64461/new/

https://reviews.llvm.org/D64461