[PATCH] D64473: [Coding style change][lld] Rename variables for non-ELF ports.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 22:33:24 PDT 2019


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/COFF/Driver.cpp:126
+    auto mbOrErr = MemoryBuffer::getFile(path,
                                          /*FileSize*/ -1,
                                          /*RequiresNullTerminator*/ false);
----------------
This tool doesn't handle argument comments like `/*FileSize*/ `.

But I think it is fine to update them in another commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64473/new/

https://reviews.llvm.org/D64473





More information about the llvm-commits mailing list