[PATCH] D61810: [BPF] add new intrinsics preserve_{array,union,struct}_access_index

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert reopened this revision.
jdoerfert added a comment.

This patch lacks tests for various parts, intrinsics, metadata, ... Also descriptions are missing.

@efriedma @eli.friedman



================
Comment at: llvm/trunk/docs/LangRef.rst:17348
+The '``llvm.preserve.array.access.index``' intrinsic produces the same result
+as a getelementptr with base ``base`` and access operands ``{dim's 0's, index}``.
+
----------------
I fail to see how what `llvm.preserve.array.access.index` preserves, at least given this description.




================
Comment at: llvm/trunk/docs/LangRef.rst:17386
+
+      declare <type2>
+      @llvm.preserve.struct.access.index.p0i8.p0s_struct.anon.0s(<type> base,
----------------
why `2` in `type2`, also above.




================
Comment at: llvm/trunk/docs/LangRef.rst:17397
+The ``llvm.preserve.access.index`` type of metadata is attached to this call instruction
+to provide struct debuginfo type.
+
----------------
Where is the description of this metadata?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61810/new/

https://reviews.llvm.org/D61810