[PATCH] D64368: [LoopUnroll] do not unroll loops containing callbr
Hal Finkel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 10 17:24:14 PDT 2019
hfinkel accepted this revision.
hfinkel added a comment.
In D64368#1579690 <https://reviews.llvm.org/D64368#1579690>, @nickdesaulniers wrote:
> > it would be good to add a test with callbr there as well, to make sure we do not miss it, in case we remove the restriction again.
>
> I agree and would be happy to do so. Would you prefer that additional test case in this commit or a subsequent commit (either way, before I re-visit https://reviews.llvm.org/D64101)?
Probably with this commit: If this gets reverted for whatever reason, that test would also need to be reverted, right?
Otherwise, LGTM too.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64368/new/
https://reviews.llvm.org/D64368
More information about the llvm-commits
mailing list