[PATCH] D64468: Replace three "strip & accumulate" implementations with a single one
Hal Finkel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 10 16:12:49 PDT 2019
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:652
///
/// This is very similar to GetPointerBaseWithConstantOffset except it doesn't
/// follow non-inbounds geps. This allows it to remain usable for icmp ult/etc.
----------------
This comment should be updated to say:
When AllowNonInbounds is false, the results are usable for icmp ult/etc. folding.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64468/new/
https://reviews.llvm.org/D64468
More information about the llvm-commits
mailing list