[PATCH] D58238: [DebugInfo] MachineSink: Insert undef DBG_VALUEs when sinking instructions, try to forward copies
Vedant Kumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 10 14:07:59 PDT 2019
vsk added inline comments.
================
Comment at: lib/CodeGen/MachineSink.cpp:801
+ TargetRegisterInfo::isVirtualRegister(SrcMO->getReg()) &&
+ DbgMO.getSubReg() == SrcMO->getSubReg() == DstMO->getSubReg() &&
+ !PostRA)
----------------
This subreg equality check seems a bit tricky. Mind breaking it up? Currently it reads like '(true|false) == DstMO->getSubReg()', which is surprising because I expected an unsigned-unsigned comparison.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58238/new/
https://reviews.llvm.org/D58238
More information about the llvm-commits
mailing list