[PATCH] D63572: [Polly][NFC][ScopBuilder] Move addRecordedAssumption to ScopBuilder

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 10:49:30 PDT 2019


Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: polly/include/polly/ScopInfo.h:2344
+  iterator_range<RecordedAssumptionsTy::reverse_iterator>
+  recorded_assumptions() {
+    return make_range(RecordedAssumptions.rbegin(), RecordedAssumptions.rend());
----------------
[suggestion] Add `const` qualifier


================
Comment at: polly/include/polly/ScopInfo.h:2345
+  recorded_assumptions() {
+    return make_range(RecordedAssumptions.rbegin(), RecordedAssumptions.rend());
+  }
----------------
Why reverse iterator? The user could also use `llvm::reverse`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63572/new/

https://reviews.llvm.org/D63572





More information about the llvm-commits mailing list