[PATCH] D64513: [GlobalISel][AArch64][NFC] Use getDefIgnoringCopies from Utils where we can

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 10:21:42 PDT 2019


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:3239-3240
-      // Copies can be from physical registers. If we hit this, we're done.
-      if (TargetRegisterInfo::isPhysicalRegister(Def->getOperand(1).getReg()))
-        break;
-      Def = MRI.getVRegDef(Def->getOperand(1).getReg());
----------------
I'm not sure getDefIgnoringCopies handles physical registers correctly, does that have a test somewhere?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64513/new/

https://reviews.llvm.org/D64513





More information about the llvm-commits mailing list