[PATCH] D64468: Replace three "strip & accumulate" implementations with a single one

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/include/llvm/IR/Value.h:565-569
+  /// Note that this function will never return a nullptr. It will also never
+  /// manipulate the \p Offset in a way that would not match the difference
+  /// between the underlying value and the returned one. Thus, if no constant
+  /// offset was found, the returned value is the underlying one and \p Offset
+  /// is unchanged.
----------------
Thanks - the nullptr note is helpful. 

I don't know the rest of this code very well, so I'll let others review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64468/new/

https://reviews.llvm.org/D64468