[PATCH] D63604: [Attributor] Deduce "nonnull" attribute

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:854
+  Value &V = *getAssociatedValue();
+
+  auto *AANonNull = A.getAAFor<AANonNullImpl>(*this, V);
----------------
uenoku wrote:
> jdoerfert wrote:
> > `isKnowNonNull(&V, ...)` ?
> >`isKnowNonNull(&V, ...)`?
> 
> Could you explain more detail?
> 
> 
> 
> 
Sorry. Any reason you do not use the `isKnownNonNull` functionality here (as you did above)? The check for an `AANonNullImpl` attribute will only succeed if the values is a call or argument.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63604/new/

https://reviews.llvm.org/D63604