[PATCH] D64497: [AMDGPU] Allow abs/neg source modifiers on v_cndmask_b32

Wed Jul 10 08:05:34 PDT 2019

arsenm added a comment.

In D64497#1578475 <https://reviews.llvm.org/D64497#1578475>, @foad wrote:

> In D64497#1578444 <https://reviews.llvm.org/D64497#1578444>, @arsenm wrote:
>
> > We still need more work to handle the integer cases in the complex pattern.
>
>
> Which pattern?

VOP3Mods only looks for FNEG and FABS, although the equivalent bit operations should also work

> 
> 
>> Plus the combine that tries to avoid source modifiers on select should be updated
> 
> Where is that? I looked but couldn't find anything like this.

Look at performFNegCombine, performFAbsCombine, fnegFoldsIntoOp and hasSourceMods

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64497/new/

https://reviews.llvm.org/D64497