[PATCH] D64393: [AMDGPU] Fix DPP combiner check for exec modification

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

In D64393#1578090 <https://reviews.llvm.org/D64393#1578090>, @vpykhtin wrote:

> Sorry, there is a code for returnining unique instr, so we can use the count:
>
>   defusechain_instr_iterator &operator++() {          // Preincrement
>         assert(Op && "Cannot increment end iterator!");
>         if (ByOperand)
>           advance();
>         else if (ByInstr) {
>           MachineInstr *P = Op->getParent();
>           do {
>             advance();
>           } while (Op && Op->getParent() == P); // <- removes duplicates
>  
>


But is it guaranteed that multiple uses by a single instruction will be adjacent in the list?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64393/new/

https://reviews.llvm.org/D64393