[PATCH] D63860: [MachineCSE] Improve CSE on phi node incoming value

Wed Jul 10 05:01:23 PDT 2019

piotr added a comment.

In D63860#1576545 <https://reviews.llvm.org/D63860#1576545>, @anton-afanasyev wrote:

> In D63860#1574717 <https://reviews.llvm.org/D63860#1574717>, @piotr wrote:
>
> > In D63860#1572882 <https://reviews.llvm.org/D63860#1572882>, @anton-afanasyev wrote:
> >
> > > Hi @piotr, have you tried regression benchmarking with this patch? For instance, test suite.
> >
> >
> > Hi Anton, Yes, I have just run regression testing on the test-suite and the tests pass ("Expected Passes    : 917").
>
>
> Hmm, I'm talking about performance benchmarking, from llvm Test Suite: https://llvm.org/docs/TestingGuide.html#test-suite.

Sorry, I referred to the entire test-suite. For MicroBenchmarks only (llvm-lit  -v -j 1 -o patch.json MicroBenchmarks) I get the following detailed results:

$python3   ../../test-suite/utils/compare.py  --filter-short orig.json patch.json
Warning: 'test-suite :: MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test' has No metrics!
Warning: 'test-suite :: MicroBenchmarks/XRay/ReturnReference/retref-bench.test' has No metrics!
Warning: 'test-suite :: MicroBenchmarks/XRay/FDRMode/fdrmode-bench.test' has No metrics!
Warning: 'test-suite :: MicroBenchmarks/XRay/ReturnReference/retref-bench.test' has No metrics!
Tests: 248
Metric: exec_time

Program                                        orig    patch   diff  
 test-suite...mbda.test:BM_PIC_2D_LAMBDA/171     3.18    0.88  -72.2%
 test-suite...alsCRaw.test:BM_PIC_2D_RAW/171     1.77    0.89  -49.8%
 test-suite...Raw.test:BM_MAT_X_MAT_RAW/5001   4520.23 6770.15 49.8% 
 test-suite...aw.test:BM_MULADDSUB_RAW/44217    47.74   69.22  45.0% 
 test-suite...lsBRaw.test:BM_INIT3_RAW/44217    33.57   47.99  42.9% 
 test-suite...ambda.test:BM_EOS_LAMBDA/44217    46.45   58.30  25.5% 
 test-suite...ENCHMARK_BILATERAL_FILTER/16/2    22.35   27.97  25.2% 
 test-suite...ENCHMARK_BILATERAL_FILTER/16/4    68.97   85.68  24.2% 
 test-suite...ENCHMARK_BILATERAL_FILTER/32/2   103.48  127.84  23.5% 
 test-suite...ENCHMARK_BILATERAL_FILTER/32/4   381.09  468.47  22.9% 
 test-suite...mbda.test:BM_ICCG_LAMBDA/44217    32.80   39.22  19.6% 
 test-suite...st:BM_INT_PREDICT_LAMBDA/44217   366.07  434.41  18.7% 
 test-suite...est:BM_INT_PREDICT_LAMBDA/5001    14.69   16.82  14.5% 
 test-suite...BRaw.test:BM_IF_QUAD_RAW/44217   148.05  168.47  13.8% 
 test-suite....test:BENCHMARK_HARRIS/256/256   389.53  346.90  -10.9%
 Geomean difference                                             nan%
 orig          patch        diff
count  232.000000     232.000000     232.000000
mean   2081.547998    2091.565842    0.007603  
std    11692.576779   11651.097661   0.091756  
min    0.030994       0.030717      -0.722465  
25%    3.198364       2.967566      -0.012795  
50%    36.165086      39.408759     -0.000642  
75%    318.340952     318.455341     0.009107  
max    115341.083667  113080.746500  0.497745

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63860/new/

https://reviews.llvm.org/D63860