[PATCH] D64474: [lld] [NFC] Match new variable names in comments

Alex Brachet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 04:09:27 PDT 2019


abrachet marked 3 inline comments as done.
abrachet added inline comments.


================
Comment at: lld/ELF/DriverUtils.cpp:149
       outs(), (config->progName + " [options] file...").str().c_str(), "lld",
-      false /*ShowHidden*/, true /*ShowAllAliases*/);
+      /*showHidden=*/false, /*showAllAliases=*/true);
   outs() << "\n";
----------------
These parameters have been unchanged it exists in include/Option [[ https://github.com/llvm-mirror/llvm/blob/master/include/llvm/Option/OptTable.h#L232 | here ]].


================
Comment at: lld/ELF/LTO.cpp:122
     checkError(c.addSaveTemps(config->outputFile.str() + ".",
-                              /*UseInputModulePath*/ true));
+                              /*useInputModulePath=*/true));
   return c;
----------------
Also has been unchanged, still UseInputModulePath.


================
Comment at: lld/ELF/LTO.cpp:223
 
-    ModuleSummaryIndex m(/*HaveGVs*/ false);
+    ModuleSummaryIndex m(/*haveGVs=*/false);
     m.setSkipModuleByDistributedBackend();
----------------
Again unchanged, still exists as HaveGVs


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64474/new/

https://reviews.llvm.org/D64474





More information about the llvm-commits mailing list