[PATCH] D64419: [MIPS GlobalISel] Select float and double load and store

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 10 03:13:31 PDT 2019


atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM with a nit



================
Comment at: lib/Target/Mips/MipsInstructionSelector.cpp:284
 
-    if (DestRegBank != Mips::GPRBRegBankID || OpSize != 32)
+    if (!((DestRegBank == Mips::GPRBRegBankID && OpSize == 32) ||
+          (DestRegBank == Mips::FPRBRegBankID &&
----------------
Let's split this complicated condition
```
if (DestRegBank == Mips::GPRBRegBankID && OpSize != 32)
  return false;

if (DestRegBank == Mips::FPRBRegBankID && OpSize != 32 && OpSize != 64)
  return false;
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64419/new/

https://reviews.llvm.org/D64419





More information about the llvm-commits mailing list