[PATCH] D64406: [ARM][AArch64] Cortex-A65AE, Neoverse E1 and Neoverse N1 support

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:95
                  (AArch64::AEK_CRC))
+AARCH64_CPU_NAME("cortex-a65ae", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,
+                 (AArch64::AEK_FP16 | AArch64::AEK_DOTPROD))
----------------
Why are you just adding `cortex-a65ae`, and not `cortex-a65`? Is that coming in a later patch?


================
Comment at: llvm/include/llvm/Support/AArch64TargetParser.def:96
+AARCH64_CPU_NAME("cortex-a65ae", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false,
+                 (AArch64::AEK_FP16 | AArch64::AEK_DOTPROD))
 AARCH64_CPU_NAME("cortex-a72", ARMV8A, FK_CRYPTO_NEON_FP_ARMV8, false,
----------------
I think all three of these cores should have `AEK_RCPC`, `AEK_SSBS` and `AEK_RAS`.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:497
+                                   FeatureDotProd
+                                   ]>;
+
----------------
I think all three of these should also have `FeatureSSBS`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64406/new/

https://reviews.llvm.org/D64406