[PATCH] D64473: [Coding style change][lld] Rename variables for non-ELF ports.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu marked 4 inline comments as done.
ruiu added inline comments.


================
Comment at: lld/COFF/Driver.h:124
+  void addBuffer(std::unique_ptr<MemoryBuffer> mb, bool wholeArchive);
+  void addArchiveBuffer(MemoryBufferRef mbref, StringRef symName,
+                        StringRef parentName, uint64_t offsetInArchive);
----------------
grimar wrote:
> `mbRef`?
I think this is fine.


================
Comment at: lld/wasm/SymbolTable.cpp:520
 // then unified later in handleSymbolVariants.
-bool SymbolTable::getFunctionVariant(Symbol* Sym, const WasmSignature *Sig,
-                                     const InputFile *File, Symbol **Out) {
+bool SymbolTable::getFunctionVariant(Symbol* sym, const WasmSignature *sig,
+                                     const InputFile *file, Symbol **out) {
----------------
grimar wrote:
> It looks unformatted. Perhaps you could apply the clang format at the same time?
It is intentional that I did not run clang-format, as some code was intended to not be formatted using clang-format. I don't judge whether that expectation is good or not, but I wanted to avoid the problem by not running clang-format to this patch. If we do, we'd virtually apply clang-format to the entire code base. That might be a good thing but needs a separate discussion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64473/new/

https://reviews.llvm.org/D64473