[PATCH] D63707: [AArch64] Define ETE and TRBE system registers

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64.td:743
+                     FeaturePostRAScheduler,
+                     FeatureETE
                      ]>;
----------------
chill wrote:
> ostannard wrote:
> > Why are you enabling this for the generic target? No existing hardware will have these instructions, so we should reject them unless they're explicitly enabled.
> That's because we have no other means to enable them, thus they are enabled by default.  Our plan is when the future architecture extensions find their place in some future architecture, then to have them enabled for that architecture only. Until then we want to make them available for people to experiment.
> 
In which case we should add an actual way to turn this on (an extension flag in targetparser), rather than hijacking an existing architecture.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63707/new/

https://reviews.llvm.org/D63707