[llvm] r365597 - Silence gcc warning by adding parentheses to condition [NFC]

Mikael Holmen via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 23:18:03 PDT 2019


Author: uabelho
Date: Tue Jul  9 23:18:03 2019
New Revision: 365597

URL: http://llvm.org/viewvc/llvm-project?rev=365597&view=rev
Log:
Silence gcc warning by adding parentheses to condition [NFC]

Without this gcc 7.4.0 complains with

  ../include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:457:54: error: suggest parentheses around '&&' within '||' [-Werror=parentheses]
                    isArtifactCast(TmpDef->getOpcode()) &&
                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
                        "Expecting copy or artifact cast here");
                        ~

Modified:
    llvm/trunk/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h

Modified: llvm/trunk/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h?rev=365597&r1=365596&r2=365597&view=diff
==============================================================================
--- llvm/trunk/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h (original)
+++ llvm/trunk/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h Tue Jul  9 23:18:03 2019
@@ -453,9 +453,9 @@ private:
       MachineInstr *TmpDef = MRI.getVRegDef(PrevRegSrc);
       if (MRI.hasOneUse(PrevRegSrc)) {
         if (TmpDef != &DefMI) {
-          assert(TmpDef->getOpcode() == TargetOpcode::COPY ||
-                 isArtifactCast(TmpDef->getOpcode()) &&
-                     "Expecting copy or artifact cast here");
+          assert((TmpDef->getOpcode() == TargetOpcode::COPY ||
+                  isArtifactCast(TmpDef->getOpcode())) &&
+                 "Expecting copy or artifact cast here");
 
           DeadInsts.push_back(TmpDef);
         }




More information about the llvm-commits mailing list