[llvm] r365589 - [X86] Limit getTargetConstantFromNode to only work on NormalLoads not extending loads.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 17:40:01 PDT 2019


Author: ctopper
Date: Tue Jul  9 17:40:01 2019
New Revision: 365589

URL: http://llvm.org/viewvc/llvm-project?rev=365589&view=rev
Log:
[X86] Limit getTargetConstantFromNode to only work on NormalLoads not extending loads.

This seems to fix a failure reported by Jordan Rupprecht, but we
don't have a reduced test case yet.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=365589&r1=365588&r2=365589&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Tue Jul  9 17:40:01 2019
@@ -5788,7 +5788,7 @@ static SDValue getShuffleVectorZeroOrUnd
 }
 
 static const Constant *getTargetConstantFromNode(LoadSDNode *Load) {
-  if (!Load)
+  if (!Load || !ISD::isNormalLoad(Load))
     return nullptr;
 
   SDValue Ptr = Load->getBasePtr();




More information about the llvm-commits mailing list