[PATCH] D57399: AMDGPU/GlobalISel: Add support for wide loads >= 256-bits

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 14:49:22 PDT 2019


tstellar updated this revision to Diff 208820.
tstellar added a comment.

I added a better comment to getOtherVRegDef.  I tried to come up with
a solution using the OperandsMapper, but in the end I had to implement
something similar to getOtherVRegDef to in order to verify that we retreived the
correct LegalizedInst from the LegalizeHelper.  It was also way more code and
might be more confusing.  Hopefully the new comment on getOtherVRegDef makes
it clear what is going on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57399/new/

https://reviews.llvm.org/D57399

Files:
  llvm/lib/Target/AMDGPU/AMDGPUGenRegisterBankInfo.def
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.h
  llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-load-smrd.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-load.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/regbankselect-load.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57399.208820.patch
Type: text/x-patch
Size: 48220 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190709/86b7aa31/attachment.bin>


More information about the llvm-commits mailing list