[PATCH] D64436: GlobalISel: Combine unmerge of merge with intermediate cast

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:298
+      if (ConvertOp) {
+        Builder.setInstr(MI);
+
----------------
Do we need to restore the builder's insertpt?


================
Comment at: include/llvm/CodeGen/GlobalISel/Utils.h:133
 /// Opcode. Also try to do trivial folding if it's a COPY with
 /// same types. Returns null otherwise.
+MachineInstr *getOpcodeDef(unsigned Opcode, Register Reg,
----------------
This comment now needs moving to getDefIgnoringCopies


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64436/new/

https://reviews.llvm.org/D64436