[PATCH] D64443: Add support for building with Python 3

[Christian Biesinger via Phabricator via llvm-commits]

cbiesinger marked an inline comment as done.
cbiesinger added inline comments.


================
Comment at: llvm/CMakeLists.txt:645
+# We support both Python 2 and 3.
+set(Python_ADDITIONAL_VERSIONS 3.6 2.7)
 include(FindPythonInterp)
----------------
mgorny wrote:
> cbiesinger wrote:
> > mgorny wrote:
> > > Wouldn't the correct thing to do be removing the list altogether?
> > Apparently not; if I do that CMake still finds Python 2.7.
> > 
> > -- Found PythonLibs: /usr/lib/x86_64-linux-gnu/libpython2.7.so (found version "2.7.16") 
> > 
> In that case, you should specify at least 3.7 as well. Maybe 3.5 if it works.
OK, done. (I don't have 3.5 to test but have no reason to assume it won't work)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64443/new/

https://reviews.llvm.org/D64443