[PATCH] D61694: Boilerplate for producing XCOFF object files from the PowerPC backend.

[James Nagurne via Phabricator via llvm-commits]

JamesNagurne added a comment.

Maybe someone can enlighten me as to why the build bots aren't tripping up on this one, but our group is running into this when we pull this commit from the upstream:

In MCStreamer.h, the declaration of the pure virtual EmitSymbolAttribute is:

  virtual bool EmitSymbolAttribute(MCSymbol *Symbol,
                                   MCSymbolAttr AttrKind,
                                   StringRef AttrVal = StringRef()) = 0;

In this revision, in MCXCOFFStreamer.h, the declaration is:

  bool EmitSymbolAttribute(MCSymbol *Symbol, MCSymbolAttr Attribute) override;

This is ill-formed, because the 'override' declaration hides the pure virtual member function. Apparently the clang-fast build bots are ok with this, but I'm not sure how. A similar code segment (Compiler Explorer <https://godbolt.org/z/1kZwyy>) fails on every clang compiler I've tried.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61694/new/

https://reviews.llvm.org/D61694