[PATCH] D64413: [ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Other than a couple of test nits, LGTM.



================
Comment at: llvm/test/MC/ARM/mve-fp-registers.s:52
+
+vpop.32    {d0-d15}
+# FP32: vpop {{.*}}                     @ encoding: [0xbd,0xec,0x20,0x0b]
----------------
I think this should be vpop.64


================
Comment at: llvm/test/MC/ARM/mve-fp-registers.s:64
+
+vpush.16    {d0-d15}
+# FP32: vpush {{.*}}                    @ encoding: [0x2d,0xed,0x20,0x0b]
----------------
same here.


================
Comment at: llvm/test/MC/ARM/mve-fp-registers.s:88
+
+vpush.16 {s0-s31}
+# FP32: vpush {{.*}}                    @ encoding: [0x2d,0xed,0x20,0x0a]
----------------
and this one vpush.32

(although none of these we seems to be very stringent on, the spec says "If present, it must be equal to the size in bits, 32 or 64, of the registers being transferred." )


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64413/new/

https://reviews.llvm.org/D64413