[PATCH] D63887: [ThinLTO] only emit used or referenced CFI records to index

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 11:17:49 PDT 2019


inglorion accepted this revision.
inglorion marked 2 inline comments as done.
inglorion added a comment.

Thanks for the review!



================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:3886
 
-  for (const auto &GVI : valueIds()) {
+  const std::map<GlobalValue::GUID, unsigned> &ValueIds = valueIds();
+  for (const auto &GVI : ValueIds) {
----------------
vitalybuka wrote:
> why do you need this change?
Thanks for spotting that! I don't need this anymore, but forgot to undo it. Undone now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63887/new/

https://reviews.llvm.org/D63887





More information about the llvm-commits mailing list