[PATCH] D64197: [HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable()

[Eric Christopher via llvm-commits]

Yes. Please revert. Also no changing things in analysis passes :)

On Tue, Jul 9, 2019, 10:42 AM Sean Fertile via Phabricator <
reviews at reviews.llvm.org> wrote:

> sfertile added a comment.
>
> In D64197#1576464 <https://reviews.llvm.org/D64197#1576464>, @sbc100
> wrote:
>
> > I tried adding a dependency on TransformUtils to Analysis/LLVMBuild.txt
> but that generated:
> >
> >   CMake Error at CMakeLists.txt:711 (message):
> >     Unexpected failure executing llvm-build: llvm-build: fatal error:
> found
> >     cycle to u'Analysis' after following: u'AArch64CodeGen' (required
> library)
> >     -> u'Analysis' (required library) -> u'TransformUtils' (required
> library)
> >     -> Analysis
> >
> >
> > Does this mean that this change violates the dependency graph?
> Assuming you can repro, with `-DBUILD_SHARED_LIBS=ON` then perhaps we can
> revert this while a solution is found?
>
>
> Between modifying the CFG in an analysis pass and breaking the shared libs
> build, I think reverting for now is a good idea.
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D64197/new/
>
> https://reviews.llvm.org/D64197
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190709/0c055edc/attachment.html>