[PATCH] D64197: [HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable()

Sterling Augustine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 10:42:37 PDT 2019


saugustine added a comment.

This revision violates some rules about the build structure.

In particular, Analysis shouldn't depend on Transforms, and the new includes in TargetTransform.cpp make it do so.

These headers would have to be moved into the includes directory for this to be a viable change.

One possible fix would be to move TargetTransform.cpp from Analysis into Transform/Utils.

I propose we that we revert this revision.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64197/new/

https://reviews.llvm.org/D64197





More information about the llvm-commits mailing list