[PATCH] D64428: Teach `llvm-pdbutil pretty -native` about `-injected-sources`

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 10:40:38 PDT 2019


thakis marked an inline comment as done.
thakis added inline comments.
Herald added a subscriber: ormris.


================
Comment at: llvm/tools/llvm-pdbutil/llvm-pdbutil.cpp:937
   auto Sources = Session.getInjectedSources();
-  if (0 == Sources->getChildCount()) {
+  if (!Sources || !Sources->getChildCount()) {
     Printer.printLine("There are no injected sources.");
----------------
(This is needed because NativeSession returns nullptr if there are no injected sources. DIASession also has a `return nullptr` in one case, but I guess it's never hit in practice?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64428/new/

https://reviews.llvm.org/D64428





More information about the llvm-commits mailing list