[PATCH] D64258: [InferFuncAttributes] extend 'dereferenceable' attribute based on loads

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D64258#1576314 <https://reviews.llvm.org/D64258#1576314>, @jdoerfert wrote:

> I do not want to block this patch but I still believe that this is the wrong way to go (middle/long term). The fact that we need to put this not in FunctionAttrs.cpp, where the other deductions live, but in InferFunctionAttrs.cpp, where we so far only annotated library functions, should be a first sign. Also, the functionality here is only one way to deduce dereferenceable, arguably, you want all the ways together such that they can benefit from each other.


I don't disagree with the long-term view. My thoughts about the risk/reward are in my comment from yesterday. I'd like to get this in for the practical/short-term advantage to the clang 9.0 release.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64258/new/

https://reviews.llvm.org/D64258