[PATCH] D64394: [MachineCSE][MachinePRE] Do not hoist common computations into loop bodies

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

> However, if CMBB is in a loop body, we might get performance degradation.

But we might also get a performance improvement, because the performance of the inner loop is more significant than that of the outer loop. This latter case seems more likely to me, but do you have performance results from the test suite, or something else, showing otherwise?

Is the problem hoisting out of a cold inner region into a hot loop? Would profiling data help? Is this really a rematerialization problem?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64394/new/

https://reviews.llvm.org/D64394