[PATCH] D64188: [NewPM] Port the MIR Printing pass to new pass manager.
    Paul Robinson via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Jul  9 09:21:29 PDT 2019
    
    
  
probinson added a comment.
Minor stylistic things. Someone who understands passes should look at this.
================
Comment at: llvm/include/llvm/CodeGen/MIRPrintingPass.h:1
+//===- MIRPrintingPass.cpp - Pass that prints out using the MIR format ----===//
+//
----------------
Filename is .h not .cpp; also, needs a 'C++' tag.
================
Comment at: llvm/lib/CodeGen/MIRPrintingPass.cpp:16
 #include "llvm/CodeGen/MIRPrinter.h"
+#include "llvm/CodeGen/PassManager.h"
 
----------------
Includes aren't sorted properly.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64188/new/
https://reviews.llvm.org/D64188
    
    
More information about the llvm-commits
mailing list