[PATCH] D64354: [AArch64][GlobalISel] Optimize conditional branches followed by unconditional branches

[Amara Emerson via Phabricator via llvm-commits]

aemerson accepted this revision.
aemerson marked an inline comment as done.
aemerson added a comment.
This revision is now accepted and ready to land.

Marking as accepted.



================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:392
+  CmpInst::Predicate InversePred = CmpInst::getInversePredicate(
+      (CmpInst::Predicate)CmpMI->getOperand(1).getPredicate());
+
----------------
aditya_nandakumar wrote:
> Orthogonal to this patch - I've found that MachineOperand::getPredicate returning an unsigned and users having to explicitly cast to Predicate is a little annoying. What do you think of getPredicate returning Predicate type (in a separate patch)? In my use cases I've almost never used the unsigned value without casting to Predicate.
That sounds reasonable to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64354/new/

https://reviews.llvm.org/D64354