[PATCH] D64285: [InstSimplify] Fold select (icmp sgt x, -1), lshr (X,  Y), ashr (X, Y) to ashr (X, Y))
    Sanjay Patel via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Jul  9 08:48:29 PDT 2019
    
        - Previous message: [PATCH] D64285: [InstSimplify] Fold select (icmp sgt x, -1), lshr (X,  Y), ashr (X, Y) to ashr (X, Y))
- Next message: [PATCH] D64285: [InstSimplify] Fold select (icmp sgt x, -1), lshr (X,  Y), ashr (X, Y) to ashr (X, Y))
-  Messages sorted by: 
              [ date ]
              [ thread ]
              [ subject ]
              [ author ]
         
  
spatel added a comment.
In D64285#1576143 <https://reviews.llvm.org/D64285#1576143>, @craig.topper wrote:
> Are we really allowed to change the exact flag from InstSimplify?
No - we're not supposed to morph existing values here.
I wasn't thinking about the 'exact' case when I made the earlier comment, so we should move this back to instcombine. Sorry about that.
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64285/new/
https://reviews.llvm.org/D64285
    
    
        
	- Previous message: [PATCH] D64285: [InstSimplify] Fold select (icmp sgt x, -1), lshr (X,  Y), ashr (X, Y) to ashr (X, Y))
- Next message: [PATCH] D64285: [InstSimplify] Fold select (icmp sgt x, -1), lshr (X,  Y), ashr (X, Y) to ashr (X, Y))
-  Messages sorted by: 
              [ date ]
              [ thread ]
              [ subject ]
              [ author ]
         
More information about the llvm-commits
mailing list