[PATCH] D63547: [AIX]Global Address Lowering
Sean Fertile via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 9 08:11:31 PDT 2019
sfertile added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCTOCRegDeps.cpp:118
+ const bool isAIXABI = Subtarget.isAIXABI();
+ assert(((isPPC64 && isSVR4ABI) || isAIXABI) &&
+ "Only supported for 64-bit SVR4 ABI and AIX ABI under large code "
----------------
Does it help readability if we add some extra helpers to the subtarget combining ABI and pointer width checks?
eg `is64BitELF()`, `is32BitAIX()` etc?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63547/new/
https://reviews.llvm.org/D63547
More information about the llvm-commits
mailing list