[PATCH] D63870: [ARM] MVE minnm and maxnm instructions

Tue Jul 9 07:13:37 PDT 2019

dmgreen marked an inline comment as done.
dmgreen added inline comments.

================
Comment at: llvm/test/CodeGen/Thumb2/mve-minmax.ll:4
+; RUN: llc -mtriple=thumbv8.1m.main-arm-none-eabi -mattr=+mve.fp -verify-machineinstrs %s -o - | FileCheck %s --check-prefix=CHECK --check-prefix=CHECK-MVEFP
+
+define arm_aapcs_vfpcc <4 x float> @maxnm_float32_t(<4 x float> %src1, <4 x float> %src2) {
----------------
SjoerdMeijer wrote:
> I am going to be annoying and ask the same question again.... I know all this gets selected when we have `HasMVEFloat`, but is it perhaps useful to check what happens when we only have `-mattr=+mve`?
This one works like all the others, with the  -mattr=+mve,+fullfp16 line checking that we expand when we don't have mve.fp. The "nofp+mve" expansion will just be a more verbose version of the same thing (it's already pretty verbose for fp16!)

The idea was that we had a test that shows nofloat+mve expansion worked correctly for some instruction, and then these tests just needed to show expansion/selection at the correct times. I haven't added that test yet though, I will do so now.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63870/new/

https://reviews.llvm.org/D63870