[PATCH] D64352: lld-link: Stop accepting /natvis and /fastfail in .drectve sections

Phabricator via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 06:31:55 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL365478: lld-link: Stop accepting /natvis and /fastfail in .drectve sections (authored by nico, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D64352?vs=208438&id=208665#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64352/new/

https://reviews.llvm.org/D64352

Files:
  lld/trunk/COFF/Driver.cpp


Index: lld/trunk/COFF/Driver.cpp
===================================================================
--- lld/trunk/COFF/Driver.cpp
+++ lld/trunk/COFF/Driver.cpp
@@ -365,10 +365,10 @@
       parseSubsystem(Arg->getValue(), &Config->Subsystem,
                      &Config->MajorOSVersion, &Config->MinorOSVersion);
       break;
+    // Only add flags here that link.exe accepts in
+    // `#pragma comment(linker, "/flag")`-generated sections.
     case OPT_editandcontinue:
-    case OPT_fastfail:
     case OPT_guardsym:
-    case OPT_natvis:
     case OPT_throwingnew:
       break;
     default:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64352.208665.patch
Type: text/x-patch
Size: 601 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190709/ca4823d8/attachment.bin>


More information about the llvm-commits mailing list