[PATCH] D64316: [ARM] MVE vector of 64bit types

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 9 03:48:52 PDT 2019


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

looks good to me



================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:337
   }
+  // We can do bitwise operations on v2i64 vectors
+  setOperationAction(ISD::AND, MVT::v2i64, Legal);
----------------
dmgreen wrote:
> SjoerdMeijer wrote:
> > Do we need to predicate this on MVE?
> Yep, we only call this if we have MVEIntegerOps. Neon is handled elsewhere and I think will promote all and/or/xors to v4i32.
Ah, of course, cheers


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64316/new/

https://reviews.llvm.org/D64316





More information about the llvm-commits mailing list