[PATCH] D55153: [ThinLTO] Implement index-based WPD

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson marked an inline comment as done.
tejohnson added inline comments.


================
Comment at: lib/Transforms/IPO/WholeProgramDevirt.cpp:882
+  for (const TypeIdOffsetVtableInfo P : TIdInfo) {
+    // VTable initializer should have only one summary (i.e. not be
+    // linkonce/weak).
----------------
pcc wrote:
> Can't the vtable be linkonce_odr if the key function is inline?
Good point. I have changed this to assert that all copies are ODR linkage if there is more than one. I also added this case to the new test.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55153/new/

https://reviews.llvm.org/D55153