[PATCH] D64371: [AArch64][GlobalISel] Use TST for comparisons when possible

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 15:47:54 PDT 2019


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

LGTM with comment fix and minor nit.



================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:810
+  default:
+    break;
+  case CmpInst::ICMP_UGT:
----------------
Can just make this default block return false and kill the return after the switch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64371/new/

https://reviews.llvm.org/D64371





More information about the llvm-commits mailing list