[PATCH] D63934: [MIR] Improve PRE condition of MachineCSE optimization
Anton Afanasyev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 8 15:19:18 PDT 2019
anton-afanasyev marked 2 inline comments as done.
anton-afanasyev added inline comments.
================
Comment at: llvm/lib/CodeGen/MachineCSE.cpp:824
auto CMBB = DT->findNearestCommonDominator(MBB, MBB1);
if (!CMBB->isLegalToHoistInto())
continue;
----------------
asbirlea wrote:
> Unrelated with this patch: Check `CMBB != nullptr`?
Good point, I haven't faced this issue, but this is actually potentially a bug. I'm to include fix right to this patch. Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63934/new/
https://reviews.llvm.org/D63934
More information about the llvm-commits
mailing list