[compiler-rt] r365399 - [Sanitizers] Remove clang_rt.sancov_{begin, end} on Solaris

[Rainer Orth via llvm-commits]

Author: ro
Date: Mon Jul  8 15:08:33 2019
New Revision: 365399

URL: http://llvm.org/viewvc/llvm-project?rev=365399&view=rev
Log:
[Sanitizers] Remove clang_rt.sancov_{begin,end} on Solaris

There's no point to manually create the __start___sancov_guards and __stop___sancov_guards
sections and labels on Solaris any longer.  They were originally introduced in
https://reviews.llvm.org/D40899 and https://reviews.llvm.org/D40903.

- The Solaris 11.4 ld supports creating them out of the box.
- We already unconditionally use Solaris 11.4 features like the ld -z gnu-version-script-compat option and fully working .preinit_array support in compiler-rt.
- The current files don't assemble on SPARC because the assembler syntax may be different between /bin/as and GNU as.

Tested on amd64-pc-solaris2.11.

Differential Revision: https://reviews.llvm.org/D63601

Removed:
    compiler-rt/trunk/lib/sanitizer_common/sancov_begin.S
    compiler-rt/trunk/lib/sanitizer_common/sancov_end.S
Modified:
    compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt

Modified: compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt?rev=365399&r1=365398&r2=365399&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt (original)
+++ compiler-rt/trunk/lib/sanitizer_common/CMakeLists.txt Mon Jul  8 15:08:33 2019
@@ -273,38 +273,6 @@ add_compiler_rt_object_libraries(RTSanit
   CFLAGS ${SANITIZER_NO_WEAK_HOOKS_CFLAGS}
   DEFS ${SANITIZER_COMMON_DEFINITIONS})
 
-if(OS_NAME MATCHES "SunOS")
-  # Solaris ld doesn't support the non-standard GNU ld extension of adding
-  # __start_SECNAME and __stop_SECNAME labels to sections whose names are
-  # valid C identifiers.  Instead we add our own definitions for the
-  # __sancov_guards section.
-  add_compiler_rt_object_libraries(SancovBegin
-    ARCHS ${SANITIZER_COMMON_SUPPORTED_ARCH}
-    SOURCES sancov_begin.S
-    CFLAGS ${SANITIZER_CFLAGS}
-    DEFS ${SANITIZER_COMMON_DEFINITIONS})
-
-  add_compiler_rt_runtime(clang_rt.sancov_begin
-    STATIC
-    ARCHS ${SANITIZER_COMMON_SUPPORTED_ARCH}
-    OBJECT_LIBS SancovBegin
-    CFLAGS ${SANITIZER_CFLAGS}
-    DEFS ${SANITIZER_COMMON_DEFINITIONS})
-
-  add_compiler_rt_object_libraries(SancovEnd
-    ARCHS ${SANITIZER_COMMON_SUPPORTED_ARCH}
-    SOURCES sancov_end.S
-    CFLAGS ${SANITIZER_CFLAGS}
-    DEFS ${SANITIZER_COMMON_DEFINITIONS})
-
-  add_compiler_rt_runtime(clang_rt.sancov_end
-    STATIC
-    ARCHS ${SANITIZER_COMMON_SUPPORTED_ARCH}
-    OBJECT_LIBS SancovEnd
-    CFLAGS ${SANITIZER_CFLAGS}
-    DEFS ${SANITIZER_COMMON_DEFINITIONS})
-endif()
-
 if(WIN32)
   add_compiler_rt_object_libraries(SanitizerCommonWeakInterception
     ${SANITIZER_COMMON_SUPPORTED_OS}

Removed: compiler-rt/trunk/lib/sanitizer_common/sancov_begin.S
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sancov_begin.S?rev=365398&view=auto
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sancov_begin.S (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sancov_begin.S (removed)
@@ -1,5 +0,0 @@
-	.type		__start___sancov_guards, at object
-	.globl		__start___sancov_guards
-        .section        __sancov_guards,"aw", at progbits
-        .p2align        2
-__start___sancov_guards:

Removed: compiler-rt/trunk/lib/sanitizer_common/sancov_end.S
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sancov_end.S?rev=365398&view=auto
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sancov_end.S (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sancov_end.S (removed)
@@ -1,5 +0,0 @@
-	.type		__stop___sancov_guards, at object
-	.globl		__stop___sancov_guards
-        .section        __sancov_guards,"aw", at progbits
-        .p2align        2
-__stop___sancov_guards: