[PATCH] D64293: [clangd] Don't insert absolute paths, give up instead.

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 11:05:47 PDT 2019


sammccall marked an inline comment as done.
sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/HeadersTests.cpp:100
       return "";
-    std::string Path = Inserter.calculateIncludePath(Inserted, MainFile);
+    auto Path = Inserter.calculateIncludePath(Inserted, MainFile);
     Action.EndSourceFile();
----------------
kadircet wrote:
> can you also log the error ?
I'm a bit confused about this - why do we need to log it in a unit test?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64293/new/

https://reviews.llvm.org/D64293





More information about the llvm-commits mailing list