[PATCH] D64326: Retire VS2015 Support

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

In D64326#1573909 <https://reviews.llvm.org/D64326#1573909>, @probinson wrote:

> So, the point of this is to be able to remove certain workarounds, rather than advance the language feature set, IIUC.
>  Note that not all workarounds can be removed if we claim our minimum is the very first release of VS2017; see my r361502, to work around something that all of the bots were happy with.
>  I'm "once burnt, twice shy" about this, because we're not verifying that our claimed minimum build compilers are actually usable.
>  What is the minimum version of VS2017 used by any bot?  Perhaps we should assert that as the minimum, which then makes it my fault for having a too-old build compiler.


Its a mixture of reasons including:

- It lets us clean out pre-VS2017 hacks (although I'm not surprised we have others that aren't going away)
- We typically only support the latest 2 versions of VS
- Avoid VS min versions getting tied to the gcc4/c++14 issues
- Its hard enough getting people to keep VS builds working as it is without trying to support versions going back too far.

Including _MSC_VER in the FIXME comment should help us strip out hacks as we go on.

I'm unclear how often the VS buildbots get updates outside of moving to a new release - we suggest applying the 'latest updates' of VS2017/19 but I don't anything enforces it, so your rL361502 <https://reviews.llvm.org/rL361502> fixes would need to stay.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64326/new/

https://reviews.llvm.org/D64326