[PATCH] D64231: [FileCheck] Simplify numeric variable interface

Mon Jul 8 10:56:54 PDT 2019

You may check http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/35408
for details. I experienced the same assertions in local builds.
Through lab.llvm.org, I found tens of failures of the same thing.

Typical call stack from that FileCheck assertion in your change:

: 'RUN: at line 15';
/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/clang -cc1
-internal-isystem
/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/lib/clang/9.0.0/include
-nostdsysteminc -verify -fopenmp-simd -x c++ -std=c++11 -DLOOP -triple
x86_64-apple-darwin10 -emit-llvm
/home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/tools/clang/test/OpenMP/taskloop_lastprivate_codegen.cpp
-o - | /home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/FileCheck
-check-prefix=SIMD-ONLY0
/home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/tools/clang/test/OpenMP/taskloop_lastprivate_codegen.cpp
--
Exit Code: 134

Command Output (stderr):
--
FileCheck: /home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/lib/Support/FileCheck.cpp:28:
void llvm::FileCheckNumericVariable::setValue(uint64_t): Assertion
`!Value && "Overwriting numeric variable's value is not allowed"'
failed.
Stack dump:
0. Program arguments:
/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/FileCheck
-check-prefix=BLOCKS
/home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/tools/clang/test/OpenMP/taskloop_lastprivate_codegen.cpp
 #0 0x000000001006b560 llvm::sys::PrintStackTrace(llvm::raw_ostream&)
(/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/FileCheck+0x1006b560)
 #1 0x000000001006b678 PrintStackTraceSignalHandler(void*)
(/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/FileCheck+0x1006b678)
 #2 0x0000000010069570 llvm::sys::RunSignalHandlers()
(/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/FileCheck+0x10069570)
 #3 0x0000000010069754 SignalHandler(int)
(/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/FileCheck+0x10069754)
 #4 0x00007fffaa8904d8 (linux-vdso64.so.1+0x4d8)
 #5 0x00007fffaa219140 raise (/lib64/power8/libc.so.6+0x69140)
 #6 0x0000000000000009
 #7 0x00007fffaa21baa8 abort (/lib64/power8/libc.so.6+0x6baa8)
 #8 0x00007fffaa20c378 __assert_fail_base (/lib64/power8/libc.so.6+0x5c378)
 #9 0x00007fffaa20c41c __assert_fail (/lib64/power8/libc.so.6+0x5c41c)
#10 0x0000000010025618
llvm::FileCheckNumericVariable::setValue(unsigned long)
(/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/FileCheck+0x10025618)
#11 0x000000001002bc8c llvm::FileCheckPattern::match(llvm::StringRef,
unsigned long&, llvm::SourceMgr const&) const
(/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/FileCheck+0x1002bc8c)
#12 0x000000001002c6e8 llvm::FileCheckString::CheckNot(llvm::SourceMgr
const&, llvm::StringRef, std::vector<llvm::FileCheckPattern const*,
std::allocator<llvm::FileCheckPattern const*> > const&,
llvm::FileCheckRequest const&, std::vector<llvm::FileCheckDiag,
std::allocator<llvm::FileCheckDiag> >*) const
(/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/FileCheck+0x1002c6e8)
#13 0x000000001002e678 llvm::FileCheckString::Check(llvm::SourceMgr
const&, llvm::StringRef, bool, unsigned long&,
llvm::FileCheckRequest&, std::vector<llvm::FileCheckDiag,
std::allocator<llvm::FileCheckDiag> >*) const
(/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/FileCheck+0x1002e678)
#14 0x000000001002ea5c llvm::FileCheck::CheckInput(llvm::SourceMgr&,
llvm::StringRef, llvm::ArrayRef<llvm::FileCheckString>,
std::vector<llvm::FileCheckDiag, std::allocator<llvm::FileCheckDiag>
>*) (/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/FileCheck+0x1002ea5c)
#15 0x0000000010006914 main
(/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/FileCheck+0x10006914)
#16 0x00007fffaa1f5b10 generic_start_main.isra.0
(/lib64/power8/libc.so.6+0x45b10)
#17 0x00007fffaa1f5d38 __libc_start_main (/lib64/power8/libc.so.6+0x45d38)
/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/tools/clang/test/OpenMP/Output/taskloop_lastprivate_codegen.cpp.script:
line 14: 87031 Done
/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/clang -cc1
-internal-isystem
/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/lib/clang/9.0.0/include
-nostdsysteminc -verify -fopenmp -x c++ -fblocks -DBLOCKS -triple
x86_64-apple-darwin10 -emit-llvm
/home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/tools/clang/test/OpenMP/taskloop_lastprivate_codegen.cpp
-o -
     87032 Aborted                 (core dumped) |
/home/buildbots/ppc64be-clang-test/clang-ppc64be/stage1/bin/FileCheck
-check-prefix=BLOCKS
/home/buildbots/ppc64be-clang-test/clang-ppc64be/llvm/tools/clang/test/OpenMP/taskloop_lastprivate_codegen.cpp

--

Thanks
- Michael

On Fri, Jul 5, 2019 at 5:50 PM Thomas Preud'homme via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:
>
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL365249: [FileCheck] Simplify numeric variable interface (authored by thopre, committed by ).
>
> Changed prior to commit:
>   https://reviews.llvm.org/D64231?vs=208183&id=208243#toc
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D64231/new/
>
> https://reviews.llvm.org/D64231
>
> Files:
>   llvm/trunk/include/llvm/Support/FileCheck.h
>   llvm/trunk/lib/Support/FileCheck.cpp
>   llvm/trunk/unittests/Support/FileCheckTest.cpp
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits